support explicit ttl #93
Conversation
|
This PR requires documentation updates. |
|
I reviewed the plugins and naming conventions look good. I agree with @WWitman that we need the docs and the plugin README files to updated. |
|
We can do a beta doc update for this feature and others that go into the next beta. But I'll need to have an idea of when the beta is scheduled, if possible, so I can plan for it. |
| @@ -35,6 +37,10 @@ module.exports.init = function(config, logger, stats) { | |||
| var keepApiKey = config.hasOwnProperty('keep-api-key') ? config['keep-api-key'] : false; | |||
| //cache api keys | |||
| cacheKey = config.hasOwnProperty("cacheKey") ? config.cacheKey : false; | |||
| //cache ttl | |||
| cacheKeyTTL = config.hasOwnProperty("cacheKeyTTL") ? config.cacheKeyTTL : 60000; | |||
There was a problem hiding this comment.
doesn't respect the default cacheKeyTTL value prev set on line 25 - avoid magic numbers. same for cacheSize
oauth/index.js
Outdated
| @@ -43,6 +46,10 @@ module.exports.init = function(config, logger, stats) { | |||
| var apiKeyHeaderName = config.hasOwnProperty('api-key-header') ? config['api-key-header'] : 'x-api-key'; | |||
| var keepAuthHeader = config.hasOwnProperty('keep-authorization-header') ? config['keep-authorization-header'] : false; | |||
| cacheKey = config.hasOwnProperty('cacheKey') ? config.cacheKey : false; | |||
| //cache ttl | |||
| cacheKeyTTL = config.hasOwnProperty("cacheKeyTTL") ? config.cacheKeyTTL : 60000; | |||
There was a problem hiding this comment.
doesn't respect the default cacheKeyTTL value prev set on line 35 - avoid magic numbers. same for other cache vars
oauthv2/index.js
Outdated
| @@ -50,6 +51,8 @@ module.exports.init = function(config, logger, stats) { | |||
| } | |||
| //token cache settings | |||
| tokenCache = config.hasOwnProperty('tokenCache') ? config.tokenCache : false; | |||
| //token cache ttl | |||
| tokenCacheTTL = config.hasOwnProperty("tokenCacheTTL") ? config.cacheKeyTTL : 60000; | |||
There was a problem hiding this comment.
doesn't respect the default tokenCacheTTL value prev set above avoid magic numbers. same for other cache vars
|
PTAL |
|
It looks like this PR was abandoned and it has conflicts. (Also, it shouldn't be changing the version.) Was this in response to a specific feature request? Is it still needed? Or can this just be closed? |
The oauth plugin will support three new parameters:
The oauthv2 plugin will support a new parameter:
The apikey plugin will support two new parameters: